Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a security issue by updating the input validation logic and variable generation used in the Helm end-to-end workflow.
- Replaces folder existence validation with strict regex‐based input checks.
- Generates “safe” environment variables by prepending a safe prefix and generating a random suffix.
Comments suppressed due to low confidence (2)
.github/workflows/_helm-e2e.yml:138
- [nitpick] The compound input validation condition is critical for security; please add inline comments or refactor it into multiple checks to improve readability and maintainability.
if [[ ! "$example" =~ ^[a-z0-9-]{1,20}$ ]] || [[ "$example" =~ \.{2} ]] || [[ "$example" == -* || "$example" == *- ]]; then
.github/workflows/_helm-e2e.yml:139
- [nitpick] Consider expanding the error message to detail all validation constraints (e.g., maximum length, prohibition of leading/trailing hyphens, and no consecutive periods) to assist users in troubleshooting input issues.
echo "Error: Invalid input - only lowercase alphanumeric and internal hyphens allowed"
chensuyue
approved these changes
Apr 29, 2025
lkk12014402
approved these changes
Apr 29, 2025
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix security issue.
Issues
https://github.com/opea-project/GenAIExamples/security/code-scanning/30
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
https://github.com/opea-project/GenAIExamples/actions/runs/14658733798/job/41138357893 test passed